Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A solution for Product Repeat Issue after filter on category listing page. #11206

Merged
merged 1 commit into from Oct 16, 2017
Merged

A solution for Product Repeat Issue after filter on category listing page. #11206

merged 1 commit into from Oct 16, 2017

Conversation

mayankzalavadia
Copy link
Contributor

@mayankzalavadia mayankzalavadia commented Oct 4, 2017

A solution for Product Repeat Issue after filter on category listing page.

Description

I have traced the issues and finally, I have found the problem. This issues #11139 is occurring just because of product position. When some products position are same on collection at that time we have faced this issue. For more detail about this issues please check #11139

Fixed Issues (if relevant)

  1. Product Repeat Isuue after filter on category listing page. #11139: Product Repeat Isuue after filter on category listing page.

Manual testing scenarios

  1. Please check Product Repeat Isuue after filter on category listing page. #11139

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mayankzalavadia
Copy link
Contributor Author

Hello, can you please assist me how can I remove commit " 5f7fcf6 " from this pull request.

@ihor-sviziev
Copy link
Contributor

@mayankzalavadia you could force push to your branch.

@mayankzalavadia
Copy link
Contributor Author

Yes, @ihor-sviziev. Can you please assist me how can I remove it from this pull request.

@ihor-sviziev
Copy link
Contributor

@mayankzalavadia you could switch your local branch to commit that do not contains your changes, then ad one commit that you need (you can use cherry pick feature) and then just use force push.

@mayankzalavadia
Copy link
Contributor Author

Hello, @ihor-sviziev.
Before commit, I have created a new branch, especially for this commit. Also, I have force push to this branch. Can you please assist me with exact commands.

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 4, 2017

@mayankzalavadia you can use following comand

git push -f origin <new_branch>:<old_branch>

Example:

git push -f origin my_new_branch:issue11139-patch

Where <new_branch> - local branch that contains correct data
<old_branch> - branch that contains incorrect data and should be replaced

@mayankzalavadia
Copy link
Contributor Author

Now I have updated the file and pass All checks. Please let me know if anything else you want.

magento-team pushed a commit that referenced this pull request Oct 12, 2017
magento-team pushed a commit that referenced this pull request Oct 12, 2017
magento-team pushed a commit that referenced this pull request Oct 12, 2017
@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 16, 2017
@magento-team magento-team merged commit 4aadf36 into magento:develop Oct 16, 2017
magento-team pushed a commit that referenced this pull request Oct 16, 2017
@mayankzalavadia
Copy link
Contributor Author

Hello Magento Team,
@magento-team, @okorshenko Why "Contributor" is not showing on My Profile. My two pull request is merged but still, it displays "Collaborator". Please let me know If I need to make any setting for that.

Thank you in advance. 👍

@okorshenko
Copy link
Contributor

Contributor is a status defined by GitHub.
Collaborator your account has been added to collaborators team to magento2 repository.
You can not control this labels. Only GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants